This repository was archived by the owner on Sep 12, 2019. It is now read-only.
update serve-functions to watch all files in functions folder, fixes #167 #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome! thank you |
|
i plain forgot to merge this PR, sorry for the delay. doing now! |
|
cli v2.11.17 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Changes the file watching mechanism to watch all files in the functions folder. Whenever any file is updated or removed, require.cache is cleared so the changes go live. This change enables hot reloading for functions with multiple files.
- Test plan
Run netlify dev and modify a file required by a function. In the console, a message will appear that the file was modified and the new code will be run correctly.
- Description for the changelog
Enable hot reloading for unbundled functions with multiple files